Enforce restrictions on selector expression per spec, fixes #416 #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uent#416 This uplifts the tests from the spec PR, projectfluent/fluent#280 and implements the selector validation to follow what `abstract.js` does in the spec. In @fluent/bundle, the invalid selectors are just accepted. Might be worth revisiting.
Pike
force-pushed
the
fix-selector-expressions
branch
from
6b879ad
to
25221c2
Compare
This was referenced Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uplifts the tests from the spec PR,
projectfluent/fluent#280
and implements the selector validation to follow what
abstract.jsdoes in the spec.
I didn't invest too much thinking in the error message. I filed #402 to rephrase our error messages to be constructive, at which point all the 4 error messages would collapse to one, describing what's actually a valid selector.
@zbraniecki also putting this into your review queue. I went ahead and did this PR as well to contextualize the spec one. Once we have those two, I'll file issues on rust and python.