-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle env variables in dynamic secret file #5835
handle env variables in dynamic secret file #5835
Conversation
Thanks for your contribution @alban-stourbe-wmx ! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
along with env secrets now secrets can also be specified from -v and -env-vars ex:
Env based secret
variables:
- key: password
value: $PASSWORD
Config file / Flag based secrets ( using -env-vars or -vars )
variables:
- key: password
- value: {{password}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- needs rebase from dev
c4aa997
to
01c62c6
Compare
Hi @tarunKoyalwar, the rebase has been made. Thank for the code added ☝️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @alban-stourbe-wmx for this update, FYI we are also working on #5841
Thanks to you and also congrats to @dwisiswant0 and @tarunKoyalwar |
Proposed changes
Add env variables in dynamic secret files.
Checklist