Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle env variables in dynamic secret file #5835

Conversation

alban-stourbe-wmx
Copy link
Contributor

Proposed changes

Add env variables in dynamic secret files.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@GeorginaReeder
Copy link

Thanks for your contribution @alban-stourbe-wmx ! :)

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

along with env secrets now secrets can also be specified from -v and -env-vars ex:

Env based secret

variables:
   - key: password
     value: $PASSWORD

Config file / Flag based secrets ( using -env-vars or -vars )

variables:
     - key: password
     - value: {{password}}

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • needs rebase from dev

@ehsandeep ehsandeep linked an issue Nov 20, 2024 that may be closed by this pull request
@alban-stourbe-wmx alban-stourbe-wmx force-pushed the feature/add-env-vars-into-variables-secret-files branch from c4aa997 to 01c62c6 Compare November 21, 2024 09:24
@alban-stourbe-wmx
Copy link
Contributor Author

  • needs rebase from dev

Hi @tarunKoyalwar, the rebase has been made. Thank for the code added ☝️

Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alban-stourbe-wmx for this update, FYI we are also working on #5841

@ehsandeep ehsandeep merged commit 2b4b058 into projectdiscovery:dev Nov 21, 2024
17 checks passed
@alban-stourbe-wmx
Copy link
Contributor Author

Thank you @alban-stourbe-wmx for this update, FYI we are also working on #5841

Thanks to you and also congrats to @dwisiswant0 and @tarunKoyalwar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Env variables to dynamic secret file variables
5 participants