Transmission of the actual image size #61
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Improper Commit Message |
sysopenci
added
Pending Developer Approval
weichenli-intel
force-pushed
the
v4l2_imge_size_1017
branch
from
02e45cb
to
1bd9cba
Compare
sysopenci
requested review from
dyang23,
feijiang1,
gkdeepa,
JeevakaPrabu,
kaushlen,
sgnanase,
shyjumon-n,
xyzhao2018 and
xzhan34
Formats such as MJPEG, the data size does not necessarily match thei frame size. This patch enhances the capability to transmit the actual size. Tracked-On: OAM-126506 Signed-off-by: Chenli Wei <[email protected]>
6ZhangWei
reviewed
Oct 18, 2024
| @@ -157,6 +157,7 @@ static void virtio_camera_control_ack(struct virtqueue *vq) | |||
| vbuf->sequence = req->resp.u.buffer.sequence; | |||
| vbuf->vb2_buf.timestamp = req->resp.u.buffer.timestamp; | |||
| vbuf->planes[0].bytesused = req->resp.u.format.size.sizeimage; | |||
| req->vb->planes[0].bytesused = req->resp.u.format.size.sizeimage; | |||
There was a problem hiding this comment.
I think line159 is enough to provide the bytesused for userspace.
Do you verify the android image released in this week or last week. It should work.
buffer info in this struct can be seen from userspace.
struct vb2_v4l2_buffer {
struct vb2_buffer vb2_buf;
__u32 flags;
__u32 field;
struct v4l2_timecode timecode;
__u32 sequence;
__s32 request_fd;
bool is_held;
struct vb2_plane planes[VB2_MAX_PLANES];
__u32 reserved;
ANDROID_KABI_RESERVE(1);
};
xyzhao2018
reviewed
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formats such as MJPEG, the data size does not necessarily match thei frame size.
This patch enhances the capability to transmit the actual size.
Tracked-On: OAM-126506