Fix for static analysis issues

Below are the issues fixed: - Buffer not null terminated - Resource leak Tracked-On: OAM-122340 Signed-off-by: Sapna <[email protected]>
projectceladon · Jul 22, 2024 · f8898d2 · f8898d2
1 parent 26942cf
commit f8898d2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/libsync.h b/libsync.h
@@ -91,6 +91,11 @@ static inline int sync_merge(const char *name, int fd1, int fd2)
 	data.fd2 = fd2;
 	strncpy(data.name, name, sizeof(data.name));
 
+	if (sizeof(data.name) < strlen(name))
+            data.name[sizeof(data.name) - 1] = '\0';
+	else
+            data.name[strlen(name)] = '\0';
+
 	do {
 		ret = ioctl(fd1, SYNC_IOC_MERGE, &data);
 	} while (ret == -1 && (errno == EINTR || errno == EAGAIN));

diff --git a/xf86drmSL.c b/xf86drmSL.c
@@ -182,6 +182,7 @@ drm_public int drmSLInsert(void *l, unsigned long key, void *value)
     }
 
     ++list->count;
+    free(entry);
     return 0;			/* Added to table */
 }