-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add forceTenantPrefix option to Tenant spec #1244
base: main
Are you sure you want to change the base?
feat(api): Add forceTenantPrefix option to Tenant spec #1244
Conversation
✅ Deploy Preview for capsule-documentation canceled.
|
@oliverbaehler what are your thoughts on this? |
I am okay with it, for a new minor release (v0.8.0) What happens when a tenant has capsule.clastix.io/tenant set to another tenant in both cases. If the option is on tenant basis true or false? |
If I am an owner of the Tenant If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry reviewed on my phone bcs im in hospital. I will verify the functionality again when i am on my pc
0e9374f
to
bee7557
Compare
The test failed for k8s 1.30.0, but unsure why? Can we re-trigger? @oliverbaehler |
I'm unsure why, the change was 3 extra test cases which pass with forceTenantPrefix true in Capsule Configuration... |
Seems fine now... |
Signed-off-by: samir-tahir <[email protected]>
bee7557
to
9193d36
Compare
@oliverbaehler - could you able to retrigger the failing test pls? |
This PR adds the option to require the tenant name prefix to it's namespace names, at the tenant level (opposed to setting globally in capsule configuration). With this users do not need to define
forceTenantPrefix
in capsule configuration if wanting to apply to certain Tenants only.This allows admins to fine grain which Tenants should be prefixed (i.e. consumer developer teams), whilst giving flexibility on other Tenants like platform team namespaces.
forceTenantPrefix
has been added in the Tenant SpecRequires users to set the
capsule.clastix.io/tenant
label for Tenants withforceTenantPrefix
set totrue
if more than 1 Tenant matches the owner as well as prefixing the Tenant name in the namespace, or just prefix the namespace with tenant name if matching to a single Tenant withforceTenantPrefix
set totrue
.