Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nodeIP nil in cnat services #661

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix nodeIP nil in cnat services #661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions calico-vpp-agent/services/service_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,14 @@ func (s *Server) GetLocalService(service *v1.Service, ep *v1.Endpoints) (localSe
clusterIP := net.ParseIP(service.Spec.ClusterIP)
nodeIP := s.getNodeIP(vpplink.IsIP6(clusterIP))
for _, servicePort := range service.Spec.Ports {
if !clusterIP.IsUnspecified() {
if !clusterIP.IsUnspecified() && len(clusterIP) > 0 {
entry := buildCnatEntryForServicePort(&servicePort, service, ep, clusterIP, false /* isNodePort */, *serviceSpec)
localService.Entries = append(localService.Entries, *entry)
}

for _, eip := range service.Spec.ExternalIPs {
extIP := net.ParseIP(eip)
if !extIP.IsUnspecified() {
if !extIP.IsUnspecified() && len(extIP) > 0 {
entry := buildCnatEntryForServicePort(&servicePort, service, ep, extIP, false /* isNodePort */, *serviceSpec)
localService.Entries = append(localService.Entries, *entry)
if IsLocalOnly(service) && len(entry.Backends) > 0 {
Expand All @@ -161,7 +161,7 @@ func (s *Server) GetLocalService(service *v1.Service, ep *v1.Endpoints) (localSe

for _, ingress := range service.Status.LoadBalancer.Ingress {
ingressIP := net.ParseIP(ingress.IP)
if !ingressIP.IsUnspecified() {
if !ingressIP.IsUnspecified() && len(ingressIP) > 0 {
entry := buildCnatEntryForServicePort(&servicePort, service, ep, ingressIP, false /* isNodePort */, *serviceSpec)
localService.Entries = append(localService.Entries, *entry)
if IsLocalOnly(service) && len(entry.Backends) > 0 {
Expand All @@ -171,7 +171,7 @@ func (s *Server) GetLocalService(service *v1.Service, ep *v1.Endpoints) (localSe
}

if service.Spec.Type == v1.ServiceTypeNodePort {
if !nodeIP.IsUnspecified() {
if !nodeIP.IsUnspecified() && len(nodeIP) > 0 {
entry := buildCnatEntryForServicePort(&servicePort, service, ep, nodeIP, true /* isNodePort */, *serviceSpec)
localService.Entries = append(localService.Entries, *entry)
}
Expand All @@ -181,7 +181,7 @@ func (s *Server) GetLocalService(service *v1.Service, ep *v1.Endpoints) (localSe
// Note: type=LoadBalancer only makes sense on cloud providers which support external load balancers and the actual
// creation of the load balancer happens asynchronously.
if service.Spec.Type == v1.ServiceTypeLoadBalancer && *service.Spec.AllocateLoadBalancerNodePorts {
if !nodeIP.IsUnspecified() {
if !nodeIP.IsUnspecified() && len(nodeIP) > 0 {
entry := buildCnatEntryForServicePort(&servicePort, service, ep, nodeIP, true /* isNodePort */, *serviceSpec)
localService.Entries = append(localService.Entries, *entry)
}
Expand Down