-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make dataplanes dual (internal plus external together) #9723
Open
VadimEisenberg
wants to merge
4
commits into
projectcalico:master
Choose a base branch
from
neureality-sdk:dual_felix_dataplane
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−3
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,32 @@ | ||||||
// Copyright © 2024 NeuReality Ltd., and its licensors. All rights reserved. | ||||||
// This software contains proprietary information of NeuReality Ltd. | ||||||
// You shall use such proprietary information only as may be permitted in writing by NeuReality Ltd. | ||||||
// All materials contained herein are the property of NeuReality Ltd. | ||||||
|
||||||
// THIS SOFTWARE IS PROVIDED BY NEUREALITY “AS IS” AND ANY | ||||||
// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||||||
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||||||
// PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL NEUREALITY OR ITS LICENSORS | ||||||
// BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | ||||||
// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, | ||||||
// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR | ||||||
// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY | ||||||
// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||||||
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||||||
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||||||
|
||||||
package dataplane | ||||||
|
||||||
type dataplaneDriverDecorator struct { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. perhaps?
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tomastigera Great points, thank you! Let me rename the decorator, and return an error in case the secondary driver returns an error. |
||||||
primaryDriver DataplaneDriver | ||||||
secondaryDriver DataplaneDriver | ||||||
} | ||||||
|
||||||
func (decorator dataplaneDriverDecorator) SendMessage(msg interface{}) error { | ||||||
decorator.secondaryDriver.SendMessage(msg) | ||||||
return decorator.primaryDriver.SendMessage(msg) // return message from the primary driver only | ||||||
} | ||||||
|
||||||
func (decorator dataplaneDriverDecorator) RecvMessage() (msg interface{}, err error) { | ||||||
return decorator.primaryDriver.RecvMessage() // receive message from the primary driver only | ||||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to use the Apache license header here (similar to in the other files in the repo). You're welcome to keep your copyright line (without "All rights reserved", which is typically used when no license is provided).
Please let me know if you have any specific concerns about submitting this under the Apache 2.0 license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewdupre Thank you for pointing my attention to this, I have fixed the header. I have no concerns about submitting this PR under the Apache 2.0 license.