Remove unmaintained github.com/golang-collections/collections dependency
#9469
+37
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency The `github.com/golang-collections/collections` module has not been updated in since July 2013. As we are only using its stack package, we can adapt the required code directly and remove this dependency. Signed-off-by: Eng Zer Jun <[email protected]>
marvin-tigera
added
release-note-required
caseydavenport
approved these changes
Nov 15, 2024
|
Thanks for the PR! This seems fine to me. |
|
/sem-approve |
caseydavenport
added
docs-not-required
marvin-tigera
removed
release-note-required
|
Hi @caseydavenport, could you please re-run the failing test? I suspect the failing test might be flaky. Thanks in advance 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
github.com/golang-collections/collectionsmodule has not been updated in since July 2013. As we are only using its stack package, we can adapt the required code directly and remove this dependency.The changes are already covered by the unit tests.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.