Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env var to disable tunnel in calico node #9443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gojoy
Copy link

@gojoy gojoy commented Nov 5, 2024

Description

When the env var CALICO_DISABLE_TUNNEL is set, the process allocate-tunnel-addrs is not started.

In our environment, we only use BGP, didn't use tunnel, we found when create/delete/update a IPPool, all calico-node will get and update node many times, it will make k8s apiserver load very high.Even if the Typha component is deployed, these problems cannot be alleviated.
We have also noticed that there is already an environment variable CALICO_DISABLE_FELIX that has a similar function.
So add an another environment variable CALICO_DISABLE_TUNNEL that can control whether to start the process allocate-tunnel-addrs or not.

Related issues/PRs

Fixs #9394

Todos

  • Tests
  • Documentation
  • Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@gojoy gojoy requested a review from a team as a code owner November 5, 2024 12:56
@marvin-tigera marvin-tigera added this to the Calico v3.30.0 milestone Nov 5, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Nov 5, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 5, 2024

CLA assistant check
All committers have signed the CLA.

@caseydavenport caseydavenport self-assigned this Nov 5, 2024
@gojoy gojoy closed this Nov 7, 2024
@marvin-tigera marvin-tigera removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Nov 7, 2024
@gojoy gojoy reopened this Nov 21, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants