-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cve): include PkgPath information in image cve UI list using sections and in CVE export #428
Conversation
455a738
to
13b10d3
Compare
I've kept the PR in Draft state temporarily as I'm seeing some local Unit Test failures which I'm not able to immediately figure out. |
Signed-off-by: Vishwas Rajashekar <vrajashe@cisco.com>
13b10d3
to
8fa9abc
Compare
Fixed! Missed to change the data testId :) There was an additional suggestion regarding whether we'd like to hide this data in mobile view. Ref: #426 (comment) Once we're all on the same page about whether to hide it, I can probably make that change in a separate PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
+ Coverage 82.82% 82.87% +0.04%
==========================================
Files 62 63 +1
Lines 1875 1880 +5
Branches 483 483
==========================================
+ Hits 1553 1558 +5
Misses 311 311
Partials 11 11 ☔ View full report in Codecov by Sentry. |
Hi @raulkele, gentle bump on this PR. Would be great to get your feedback. Thanks! |
Code looks good, only one small syntactic sugar suggestion. |
Like this better than PR #426 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
See project-zot/zui#428 for details Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
See project-zot/zui#428 for details Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
What type of PR is this?
feature
Which issue does this PR fix:
Towards project-zot/zot#2175
What does this PR do / Why do we need it:
This PR displays the Package Path information for the package list for a given CVE in the vulnerabilities list.
Since there is more data being displayed, this PR also brings in a change to display this information in a vertically stacked form with a separate section for each affected package.
References #426
Testing done on this change:
Screenshots:
CSV export:
XLSX export:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Ideally, this should not break upgrades or downgrades as the older graphQL query should continue working just fine as well as the updated query.
No, updating a running cluster has not been tested.
Does this change require updates to the CNI daemonset config files to work?:
N/A
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.