patch: signature display redesign #427
Conversation
Andreea-Lupu
force-pushed
the
signature_redesign
branch
from
62019b9 to
4022e3d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 82.70% 84.21% +1.51%
==========================================
Files 63 63
Lines 1885 1939 +54
Branches 485 529 +44
==========================================
+ Hits 1559 1633 +74
+ Misses 315 296 -19
+ Partials 11 10 -1 ☔ View full report in Codecov by Sentry. |
|
Attaching some issues with aligning the icons. This is for the tag details in case of cosign icons: This is for the repo card in case of unsigned images. As a separate note, I had the same signature type icon is shown multiple times if there are multiple signatures available. Is this intended? |
|
This doesn't seem to be the case for other places where we display signatures. |
Andreea-Lupu
force-pushed
the
signature_redesign
branch
3 times, most recently
from
72c6ad8 to
be884e5
Compare
|
Make it a single icon |
|
Conclusion is to show a single icon per signing tool |
Andreea-Lupu
force-pushed
the
signature_redesign
branch
4 times, most recently
from
e965241 to
0d86a6e
Compare
Signed-off-by: Raul-Cristian Kele <[email protected]> Signed-off-by: Andreea-Lupu <[email protected]>
Andreea-Lupu
force-pushed
the
signature_redesign
branch
from
0d86a6e to
196b88f
Compare
|
@Andreea-Lupu, @raulkele, thank you again for this feature! |
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.