Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the official icon #387

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: use the official icon #387

merged 1 commit into from
Oct 12, 2023

Conversation

rchincha
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #387 (1b2df3e) into main (b787273) will increase coverage by 0.64%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   86.09%   86.73%   +0.64%     
==========================================
  Files          53       53              
  Lines        1546     1553       +7     
  Branches      409      406       -3     
==========================================
+ Hits         1331     1347      +16     
+ Misses        202      193       -9     
  Partials       13       13              

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out and the icon is not shown at all.

@rchincha rchincha force-pushed the icons branch 3 times, most recently from 36e9174 to d61cbe1 Compare October 4, 2023 21:34
@rchincha rchincha force-pushed the icons branch 2 times, most recently from 03246d3 to 41cca78 Compare October 9, 2023 22:07
Signed-off-by: Ramkumar Chinchani <[email protected]>
Copy link
Collaborator

@raulkele raulkele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 19e366e into project-zot:main Oct 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants