Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update zui version #2852

Merged
merged 2 commits into from
Dec 26, 2024
Merged

chore: update zui version #2852

merged 2 commits into from
Dec 26, 2024

Conversation

rchincha
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Ramkumar Chinchani <[email protected]>
@rchincha rchincha requested a review from andaaron as a code owner December 26, 2024 09:08
andaaron
andaaron previously approved these changes Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (6ca9c66) to head (46047a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2852   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files         170      170           
  Lines       30282    30282           
=======================================
  Hits        27824    27824           
  Misses       1829     1829           
  Partials      629      629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andaaron
Copy link
Contributor

andaaron commented Dec 26, 2024

The zap scan error is actually related to the artifact name used in results, this should be fixed if we give each artifact different names (for zot minimal vs zot images). I pushed a commit to your branch to fix this.

@andaaron andaaron merged commit ab43515 into project-zot:main Dec 26, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants