Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate to golang 1.23.x #2701

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

rchincha
Copy link
Contributor

@rchincha rchincha commented Oct 3, 2024

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha rchincha requested a review from andaaron as a code owner October 3, 2024 18:25
Signed-off-by: Ramkumar Chinchani <[email protected]>
andaaron
andaaron previously approved these changes Nov 7, 2024
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ramkumar Chinchani <[email protected]>
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (a76bfd4) to head (0cab164).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/ldap.go 0.00% 0 Missing and 2 partials ⚠️
pkg/test/oci-utils/oci_layout.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2701      +/-   ##
==========================================
- Coverage   91.94%   91.93%   -0.01%     
==========================================
  Files         170      170              
  Lines       30124    30124              
==========================================
- Hits        27697    27695       -2     
- Misses       1804     1806       +2     
  Partials      623      623              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rchincha rchincha merged commit 5465aa0 into project-zot:main Nov 8, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants