Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the non-free 4-core runners #2694

Closed
wants to merge 1 commit into from

Conversation

jeefy
Copy link
Contributor

@jeefy jeefy commented Sep 30, 2024

What type of PR is this?
cleanup

What does this PR do / Why do we need it:
Optimizing GitHub Actions usage

Will this break upgrades or downgrades?
No

Does this PR introduce any user-facing change?:
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


Heya! Friendly neighborhood CNCF staffer here. The ubuntu-latest runner is already a 4-core runner, so using a hosted 4-core runner is unnecessary (and actually costs money). This PR just swaps any 4-core hosted runners to use ubuntu-latest. There should be zero change or impact, functionally this is a SKU change.

Please reach out to me in the CNCF/K8s slack(s) (jeefy) or via email ([email protected]) with any questions.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (9cf6b02) to head (3aa5f34).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2694   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files         169      169           
  Lines       22529    22529           
=======================================
  Hits        20884    20884           
  Misses       1026     1026           
  Partials      619      619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rchincha
Copy link
Contributor

@jeefy thanks, will take care of this.

@rchincha
Copy link
Contributor

@jeefy
PR #2695 is merged. Clustering tests are failing, we will take a look.
Closing this PR.

@rchincha rchincha closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants