Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix dependabot alerts #2670

Merged
merged 1 commit into from
Sep 25, 2024
Merged

chore: fix dependabot alerts #2670

merged 1 commit into from
Sep 25, 2024

Conversation

rchincha
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha rchincha requested a review from andaaron as a code owner September 20, 2024 20:04
@rchincha rchincha force-pushed the fix-deps1 branch 2 times, most recently from 24fccac to 9626740 Compare September 23, 2024 16:15
@rchincha
Copy link
Contributor Author

  • zotregistry.dev/zot/pkg/common/common_test.go
    Line 123:
    Expected: true
    Actual: false

120 Convey("Test AreSocketsEqual with equal IPv6 sockets", t, func() {
121 result, err := common.AreSocketsEqual("[::1]:9000", "[0000:0000:0000:0000:0000:0000:0000:00001]:9000")
122 So(err, ShouldBeNil)
123 So(result, ShouldBeTrue)

@andaaron
Copy link
Contributor

121 result, err := common.AreSocketsEqual("[::1]:9000", "[0000:0000:0000:0000:0000:0000:0000:00001]:9000")

Is that a typo? There is an extra 0 next to the last 1 in the second address.

Signed-off-by: Ramkumar Chinchani <[email protected]>
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (db888fa) to head (b78ad35).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2670   +/-   ##
=======================================
  Coverage   92.69%   92.70%           
=======================================
  Files         169      169           
  Lines       22529    22529           
=======================================
+ Hits        20884    20886    +2     
+ Misses       1027     1025    -2     
  Partials      618      618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rchincha rchincha merged commit ae185f4 into project-zot:main Sep 25, 2024
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants