Add a job to check zot config examples (and fix existing examples) #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2322 +/- ##
=======================================
Coverage 92.86% 92.86%
=======================================
Files 166 166
Lines 22022 22035 +13
=======================================
+ Hits 20450 20463 +13
Misses 979 979
Partials 593 593 ☔ View full report in Codecov by Sentry. |
andaaron
requested review from
rchincha and
eusebiu-constantin-petu-dbk
as code owners
(cherry picked from commit e7fdfa0) Signed-off-by: Andrei Aaron <[email protected]>
Signed-off-by: onidoru <[email protected]> Signed-off-by: Nikita Kotikov <[email protected]> (cherry picked from commit cbc0f89) Signed-off-by: Andrei Aaron <[email protected]>
Signed-off-by: onidoru <[email protected]> Signed-off-by: Nikita Kotikov <[email protected]> (cherry picked from commit b74366d) Signed-off-by: Andrei Aaron <[email protected]>
Signed-off-by: onidoru <[email protected]> Signed-off-by: Nikita Kotikov <[email protected]> (cherry picked from commit 8a61bbc) Signed-off-by: Andrei Aaron <[email protected]>
Signed-off-by: Andrei Aaron <[email protected]>
|
CI failures? |
Do you want me to signoff the cherry-picked commit with the original author's email? WRT to the coverage I could fix that by using viper.UnmarshalExact and removing some checks which would never be hit in that case. I just thought this form of the code is more easy to read. |
|
DCO check is complaining about: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase and fix coverage issues in #2215.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.