-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: more accurate storage metrics after zot restart #1972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adodon2go
requested review from
eusebiu-constantin-petu-dbk,
rchincha and
andaaron
as code owners
October 30, 2023 11:33
Codecov Report
@@ Coverage Diff @@
## main #1972 +/- ##
==========================================
- Coverage 89.87% 89.86% -0.02%
==========================================
Files 158 158
Lines 26978 27033 +55
==========================================
+ Hits 24246 24292 +46
- Misses 2012 2018 +6
- Partials 720 723 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adodon2go
force-pushed
the
fix-storage-metrics
branch
from
October 30, 2023 21:01
f77064d
to
0989469
Compare
adodon2go
force-pushed
the
fix-storage-metrics
branch
3 times, most recently
from
October 31, 2023 18:15
cf6948c
to
8124ef8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
Signed-off-by: Alexei Dodon <[email protected]>
adodon2go
force-pushed
the
fix-storage-metrics
branch
from
November 1, 2023 13:53
8124ef8
to
6da22d7
Compare
eusebiu-constantin-petu-dbk
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#1965
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.