Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more accurate storage metrics after zot restart #1972

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

adodon2go
Copy link
Collaborator

What type of PR is this?
bug

Which issue does this PR fix:
#1965

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1972 (6da22d7) into main (3e6053e) will decrease coverage by 0.02%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
- Coverage   89.87%   89.86%   -0.02%     
==========================================
  Files         158      158              
  Lines       26978    27033      +55     
==========================================
+ Hits        24246    24292      +46     
- Misses       2012     2018       +6     
- Partials      720      723       +3     
Files Coverage Δ
pkg/api/controller.go 92.83% <100.00%> (+0.14%) ⬆️
pkg/extensions/monitoring/common.go 100.00% <100.00%> (ø)
pkg/extensions/monitoring/extension.go 87.32% <100.00%> (ø)
pkg/extensions/monitoring/minimal.go 99.10% <100.00%> (ø)
pkg/storage/imagestore/imagestore.go 86.93% <100.00%> (+0.11%) ⬆️
pkg/storage/common/common.go 93.00% <91.89%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adodon2go adodon2go force-pushed the fix-storage-metrics branch from f77064d to 0989469 Compare October 30, 2023 21:01
@adodon2go adodon2go self-assigned this Oct 31, 2023
@adodon2go adodon2go force-pushed the fix-storage-metrics branch 3 times, most recently from cf6948c to 8124ef8 Compare October 31, 2023 18:15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@adodon2go adodon2go force-pushed the fix-storage-metrics branch from 8124ef8 to 6da22d7 Compare November 1, 2023 13:53
@rchincha rchincha merged commit a79d79a into project-zot:main Nov 1, 2023
32 of 33 checks passed
@adodon2go adodon2go deleted the fix-storage-metrics branch November 2, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: zot storage metrics needs to be more accurate with what is actually saved on disk
3 participants