Scheduler shutdown gracefully #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
force-pushed
the
scheduler_shutdown_gracefully
branch
3 times, most recently
from
c951284 to
22be2ef
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1951 +/- ##
==========================================
+ Coverage 91.87% 91.88% +0.01%
==========================================
Files 165 165
Lines 28125 28168 +43
==========================================
+ Hits 25840 25883 +43
- Misses 1687 1688 +1
+ Partials 598 597 -1 ☔ View full report in Codecov by Sentry. |
eusebiu-constantin-petu-dbk
force-pushed
the
scheduler_shutdown_gracefully
branch
from
22be2ef to
e1dde1e
Compare
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
|
this will wait on all scheduler goroutines to finish when server is shutting down. it will fix these types of test racing errors: 2023-10-20T08:06:10.2729247Z testing.go:1206: TempDir RemoveAll cleanup: unlinkat /tmp/TestPeriodicallySignaturesErr2733177038: directory not empty |
eusebiu-constantin-petu-dbk
force-pushed
the
scheduler_shutdown_gracefully
branch
from
e1dde1e to
baafdc7
Compare
|
Conflicts and rebase? |
eusebiu-constantin-petu-dbk
force-pushed
the
scheduler_shutdown_gracefully
branch
3 times, most recently
from
ea3cc32 to
5ad1c4f
Compare
eusebiu-constantin-petu-dbk
requested a review
from shimish2
as a code owner
eusebiu-constantin-petu-dbk
force-pushed
the
scheduler_shutdown_gracefully
branch
5 times, most recently
from
37f4d99 to
2a9453d
Compare
andaaron
reviewed
Nov 17, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
scheduler_shutdown_gracefully
branch
4 times, most recently
from
966ca4d to
2537af6
Compare
wait for workers to finish before exiting should fix tests reporting they couldn't remove rootDir because it's being written by tasks Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
scheduler_shutdown_gracefully
branch
from
2537af6 to
c6eaabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.