-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tests refactoring #1950
Merged
Merged
fix: tests refactoring #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaaron
previously approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
adodon2go
force-pushed
the
test-refactoring
branch
2 times, most recently
from
October 20, 2023 20:17
e69bea7
to
1d5db6a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1950 +/- ##
==========================================
+ Coverage 91.85% 91.91% +0.05%
==========================================
Files 155 155
Lines 26790 26807 +17
==========================================
+ Hits 24608 24639 +31
+ Misses 1615 1606 -9
+ Partials 567 562 -5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adodon2go
force-pushed
the
test-refactoring
branch
from
October 21, 2023 16:50
1d5db6a
to
f88abb8
Compare
adodon2go
force-pushed
the
test-refactoring
branch
2 times, most recently
from
October 24, 2023 11:56
6d31eda
to
829146e
Compare
adodon2go
requested review from
eusebiu-constantin-petu-dbk,
shimish2 and
rchincha
as code owners
October 24, 2023 11:56
adodon2go
force-pushed
the
test-refactoring
branch
from
October 24, 2023 16:58
829146e
to
885b2a9
Compare
rchincha
reviewed
Oct 25, 2023
adodon2go
force-pushed
the
test-refactoring
branch
from
October 25, 2023 19:51
885b2a9
to
e3b3f1e
Compare
Signed-off-by: Alexei Dodon <[email protected]>
adodon2go
force-pushed
the
test-refactoring
branch
from
October 26, 2023 06:32
e3b3f1e
to
2ccbb7a
Compare
Andreea-Lupu
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
refactoring
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.