Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests refactoring #1950

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

adodon2go
Copy link
Collaborator

What type of PR is this?
refactoring

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

andaaron
andaaron previously approved these changes Oct 20, 2023
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adodon2go adodon2go force-pushed the test-refactoring branch 2 times, most recently from e69bea7 to 1d5db6a Compare October 20, 2023 20:17
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #1950 (2ccbb7a) into main (a3d8202) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1950      +/-   ##
==========================================
+ Coverage   91.85%   91.91%   +0.05%     
==========================================
  Files         155      155              
  Lines       26790    26807      +17     
==========================================
+ Hits        24608    24639      +31     
+ Misses       1615     1606       -9     
+ Partials      567      562       -5     
Files Coverage Δ
pkg/test/common/fs.go 87.42% <100.00%> (+6.02%) ⬆️
pkg/test/common/utils.go 92.79% <100.00%> (+1.78%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adodon2go adodon2go force-pushed the test-refactoring branch 2 times, most recently from 6d31eda to 829146e Compare October 24, 2023 11:56
@adodon2go adodon2go marked this pull request as ready for review October 24, 2023 11:56
@adodon2go adodon2go self-assigned this Oct 25, 2023
pkg/test/common/utils.go Outdated Show resolved Hide resolved
Signed-off-by: Alexei Dodon <[email protected]>
@adodon2go adodon2go merged commit d2fbd27 into project-zot:main Oct 26, 2023
33 checks passed
@adodon2go adodon2go deleted the test-refactoring branch October 26, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants