fix(tests): update imagetrust tests to use mock service #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andreea-Lupu
requested review from
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
andaaron
previously approved these changes
Oct 16, 2023
rchincha
reviewed
Oct 17, 2023
Andreea-Lupu
force-pushed
the
fix_secret_already_exists_err
branch
2 times, most recently
from
65f8da2 to
6c6662b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1929 +/- ##
==========================================
+ Coverage 91.84% 91.85% +0.01%
==========================================
Files 155 155
Lines 26667 26678 +11
==========================================
+ Hits 24492 24506 +14
+ Misses 1609 1607 -2
+ Partials 566 565 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Andreea-Lupu
force-pushed
the
fix_secret_already_exists_err
branch
from
6c6662b to
404ee23
Compare
- use secretsManagerMock and secretsManagerCacheMock to avoid failing because of "already exists" error when running multiple times image_trust_test on the same localstack instance Signed-off-by: Andreea-Lupu <[email protected]>
Andreea-Lupu
force-pushed
the
fix_secret_already_exists_err
branch
from
404ee23 to
0189605
Compare
andaaron
approved these changes
Oct 18, 2023
eusebiu-constantin-petu-dbk
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.