ci: update localstack to 2.3.1 #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramkumar Chinchani <[email protected]>
rchincha
requested review from
andaaron and
eusebiu-constantin-petu-dbk
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1869 +/- ##
==========================================
- Coverage 92.05% 92.04% -0.02%
==========================================
Files 152 152
Lines 26472 26472
==========================================
- Hits 24368 24365 -3
- Misses 1554 1557 +3
Partials 550 550 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adodon2go
approved these changes
Sep 29, 2023
| @@ -20,9 +20,9 @@ runs: | |||
| password: ${{ inputs.password }} | |||
| - shell: bash | |||
| run: | | |||
| pip install localstack==2.2.0 # Install LocalStack cli | |||
| pip install localstack==2.3.1 # Install LocalStack cli | |||
| # Below image was copied manually from localstack/localstack:2.2 and uploaded to ghcr | |||
There was a problem hiding this comment.
Update the comment too (maybe without tag).
The ideea of the comment is to know after a while where is the original image on docker hub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.