Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix container image targets #1856

Merged

Conversation

rchincha
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1856 (748f061) into main (2fd7bfc) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1856      +/-   ##
==========================================
+ Coverage   92.04%   92.07%   +0.03%     
==========================================
  Files         152      152              
  Lines       26455    26455              
==========================================
+ Hits        24350    24358       +8     
+ Misses       1555     1549       -6     
+ Partials      550      548       -2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Makefile Show resolved Hide resolved
@rchincha rchincha force-pushed the sagikazarmark-docker-cross-compile branch from ef070d6 to 962b7cb Compare September 26, 2023 17:22
@rchincha rchincha changed the title Sagikazarmark docker cross compile build: fix container image targets Sep 26, 2023
@rchincha rchincha force-pushed the sagikazarmark-docker-cross-compile branch from 962b7cb to b45c74a Compare September 26, 2023 17:29
@rchincha rchincha force-pushed the sagikazarmark-docker-cross-compile branch from b45c74a to 50c7689 Compare September 26, 2023 19:15
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
build/Dockerfile-minimal Show resolved Hide resolved
build/Dockerfile-zb Show resolved Hide resolved
build/Dockerfile-zxp Show resolved Hide resolved
build/Dockerfile-conformance Outdated Show resolved Hide resolved
build/Dockerfile-minimal Outdated Show resolved Hide resolved
build/Dockerfile-zb Outdated Show resolved Hide resolved
build/Dockerfile-zxp Outdated Show resolved Hide resolved
@rchincha rchincha force-pushed the sagikazarmark-docker-cross-compile branch from 50c7689 to b0fd24c Compare October 1, 2023 05:42
@rchincha rchincha requested review from andaaron and adodon2go October 1, 2023 06:04
@rchincha rchincha force-pushed the sagikazarmark-docker-cross-compile branch from b0fd24c to 0ea5a34 Compare October 2, 2023 17:08
Use stacker to build OCI image.
Use podman/docker to build docker image.

Signed-off-by: Ramkumar Chinchani <[email protected]>
@rchincha rchincha force-pushed the sagikazarmark-docker-cross-compile branch from 0ea5a34 to 748f061 Compare October 2, 2023 17:29
@rchincha
Copy link
Contributor Author

rchincha commented Oct 2, 2023

Added a nightly test just in case

@rchincha rchincha merged commit c640735 into project-zot:main Oct 4, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants