-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix container image targets #1856
Merged
rchincha
merged 1 commit into
project-zot:main
from
rchincha:sagikazarmark-docker-cross-compile
Oct 4, 2023
Merged
build: fix container image targets #1856
rchincha
merged 1 commit into
project-zot:main
from
rchincha:sagikazarmark-docker-cross-compile
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchincha
requested review from
andaaron and
eusebiu-constantin-petu-dbk
as code owners
September 25, 2023 19:03
Codecov Report
@@ Coverage Diff @@
## main #1856 +/- ##
==========================================
+ Coverage 92.04% 92.07% +0.03%
==========================================
Files 152 152
Lines 26455 26455
==========================================
+ Hits 24350 24358 +8
+ Misses 1555 1549 -6
+ Partials 550 548 -2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adodon2go
reviewed
Sep 26, 2023
rchincha
force-pushed
the
sagikazarmark-docker-cross-compile
branch
from
September 26, 2023 17:22
ef070d6
to
962b7cb
Compare
rchincha
changed the title
Sagikazarmark docker cross compile
build: fix container image targets
Sep 26, 2023
rchincha
force-pushed
the
sagikazarmark-docker-cross-compile
branch
from
September 26, 2023 17:29
962b7cb
to
b45c74a
Compare
andaaron
reviewed
Sep 26, 2023
rchincha
force-pushed
the
sagikazarmark-docker-cross-compile
branch
from
September 26, 2023 19:15
b45c74a
to
50c7689
Compare
adodon2go
reviewed
Sep 26, 2023
adodon2go
reviewed
Sep 26, 2023
andaaron
reviewed
Sep 27, 2023
rchincha
force-pushed
the
sagikazarmark-docker-cross-compile
branch
from
October 1, 2023 05:42
50c7689
to
b0fd24c
Compare
rchincha
force-pushed
the
sagikazarmark-docker-cross-compile
branch
from
October 2, 2023 17:08
b0fd24c
to
0ea5a34
Compare
Use stacker to build OCI image. Use podman/docker to build docker image. Signed-off-by: Ramkumar Chinchani <[email protected]>
rchincha
force-pushed
the
sagikazarmark-docker-cross-compile
branch
from
October 2, 2023 17:29
0ea5a34
to
748f061
Compare
Added a nightly test just in case |
adodon2go
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.