refactor(scrub): replace umoci logic in scrub implementation #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaaron
reviewed
Sep 22, 2023
|
Why do we still have umoci in go.mod? |
Codecov Report
@@ Coverage Diff @@
## main #1845 +/- ##
==========================================
+ Coverage 91.99% 92.05% +0.06%
==========================================
Files 146 146
Lines 26462 26465 +3
==========================================
+ Hits 24343 24363 +20
+ Misses 1563 1552 -11
+ Partials 556 550 -6
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Andreea-Lupu
force-pushed
the
refactor_scrub
branch
from
b8f4d67 to
b2102d6
Compare
andaaron
reviewed
Sep 25, 2023
- implement scrub also for S3 storage by replacing umoci - change scrub implementation for ImageIndex - take the `Subject` into consideration when running scrub - remove test code relying on the umoci library. Since we started relying on images in test/data, and we create our own images using go code we can obtain digests by other means. (cherry picked from commit 489d4e2) Signed-off-by: Andrei Aaron <[email protected]> Signed-off-by: Andreea-Lupu <[email protected]>
Andreea-Lupu
force-pushed
the
refactor_scrub
branch
from
b2102d6 to
e25d343
Compare
Andreea-Lupu
requested review from
shimish2,
eusebiu-constantin-petu-dbk and
rchincha
as code owners
andaaron
approved these changes
Sep 26, 2023
This was referenced Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subjectinto consideration when running scrubrelying on images in test/data, and we create our own images using
go code we can obtain digests by other means. (cherry picked from commit andaaron@489d4e2)
What type of PR is this?
Which issue does this PR fix:
#1685 #734
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.