fix(dedupe): run dedupe only for repositories found at startup #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
andaaron
reviewed
Sep 22, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
startup_dedupe
branch
3 times, most recently
from
7da603e to
61fbbbe
Compare
andaaron
previously approved these changes
Sep 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #1844 +/- ##
==========================================
- Coverage 92.03% 92.03% -0.01%
==========================================
Files 146 146
Lines 26465 26492 +27
==========================================
+ Hits 24358 24381 +23
- Misses 1556 1559 +3
- Partials 551 552 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Pls fix the conflict. |
|
Pls fix conflicts. |
eusebiu-constantin-petu-dbk
force-pushed
the
startup_dedupe
branch
from
61fbbbe to
60671db
Compare
no need to run dedupe/restore blobs for images being pushed or synced while running dedupe task, they are already deduped/restored inline. Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
startup_dedupe
branch
from
60671db to
41e9702
Compare
andaaron
approved these changes
Sep 27, 2023
rchincha
reviewed
Sep 27, 2023
| /* at first run get from storage currently found repositories so that we skip the ones that gets synced/uploaded | ||
| while this generator runs, there are deduped/restored inline, no need to run dedupe/restore again */ | ||
| if len(gen.repos) == 0 { | ||
| gen.repos, err = gen.ImgStore.GetRepositories() |
There was a problem hiding this comment.
This list could be very large potentially
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no need to run dedupe/restore blobs for images being pushed or synced while running dedupe task, they are already deduped/restored inline.
What type of PR is this?
bug
Which issue does this PR fix:
#1843
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.