Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce test run time #1832

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

adodon2go
Copy link
Collaborator

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1832 (cf3c793) into main (ba6f347) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
+ Coverage   92.05%   92.08%   +0.02%     
==========================================
  Files         152      152              
  Lines       26472    26472              
==========================================
+ Hits        24370    24376       +6     
+ Misses       1552     1548       -4     
+ Partials      550      548       -2     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adodon2go adodon2go force-pushed the reduce-test-time branch 8 times, most recently from 9942f40 to 54edf36 Compare September 22, 2023 12:01
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a very good proposal

.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
.github/workflows/golangci-lint.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@adodon2go adodon2go changed the title DO NOT REVIEW fix: reduce test run time fix: reduce test run time Sep 22, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

.github/workflows/codeql-analysis.yaml Outdated Show resolved Hide resolved
pkg/cli/client/image_cmd_internal_test.go Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
.github/dependabot.yaml Outdated Show resolved Hide resolved
@adodon2go adodon2go self-assigned this Sep 25, 2023
@adodon2go adodon2go force-pushed the reduce-test-time branch 4 times, most recently from 4ba705e to 55b3dc9 Compare September 26, 2023 14:00
andaaron
andaaron previously approved these changes Sep 26, 2023
andaaron
andaaron previously approved these changes Sep 26, 2023
@rchincha
Copy link
Contributor

rchincha commented Sep 27, 2023

Build parts and test parts need to be mandatory.
Code coverage part too.

@rchincha
Copy link
Contributor

codeql-analysys.yaml -> .yml

@adodon2go adodon2go force-pushed the reduce-test-time branch 2 times, most recently from a9318ad to 7fdaa14 Compare September 28, 2023 11:23
andaaron
andaaron previously approved these changes Sep 28, 2023
Signed-off-by: Alexei Dodon <[email protected]>
@rchincha
Copy link
Contributor

rchincha commented Sep 28, 2023

Build and test ZOT (darwin, amd64) Expected — Waiting for status to be reported
Required
Build and test ZOT (linux, amd64) Expected — Waiting for status to be reported
Required

cc: @andaaron

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adodon2go adodon2go enabled auto-merge (squash) September 28, 2023 17:52
@adodon2go adodon2go disabled auto-merge September 28, 2023 17:52
@andaaron andaaron merged commit 3a9a932 into project-zot:main Sep 28, 2023
33 checks passed
@adodon2go adodon2go deleted the reduce-test-time branch September 29, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test][Investigate] run tests in parallel github jobs in order to cut test time
3 participants