fix: enable TLS based on URL scheme for sync extension (#2747)

Signed-off-by: evanebb <[email protected]>

pkg/extensions/sync/httpclient/client.go

@@ -115,9 +115,11 @@ func (httpClient *Client) SetConfig(config Config) error {
 
 	httpClient.url = clientURL
 
+	// we want TLS enabled if the upstream registry URL is an HTTPS URL
+	tlsEnabled := clientURL.Scheme == "https"
+
 	clientOpts := common.HTTPClientOptions{
-		// we want TLS enabled when verifyTLS is true.
-		TLSEnabled: config.TLSVerify,
+		TLSEnabled: tlsEnabled,
 		VerifyTLS:  config.TLSVerify,
 		Host:       clientURL.Host,
 	}