Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Immutable Tags article #165

Merged

Conversation

nvtkaszpir
Copy link
Contributor

Fixes #164

What type of PR is this?

Which issue does this PR fix:
#164

What does this PR do / Why do we need it:
Easier to find content without searching

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvtkaszpir can you also pls sign your commit?

@nvtkaszpir
Copy link
Contributor Author

nvtkaszpir commented Mar 17, 2024

But it is already? (see 30beda9 (#165) and 'Signed-off-by' there)
Looks like GitHub web sometimes does not show the verified/signed flag on the commits, but AFAIR the DCO github action checks this and would fail otherwise.

@nvtkaszpir nvtkaszpir requested a review from rchincha March 17, 2024 23:11
@rchincha
Copy link
Contributor

But it is already? (see 30beda9 (#165) and 'Signed-off-by' there)

Indeed, but also gpg sign the commit, so they show up as "Verified" like below.
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

https://github.com/project-zot/project-zot.github.io/commits/main/

We can merge this PR after that.

@nvtkaszpir nvtkaszpir force-pushed the immutable-tags-article-link-fix branch from 30beda9 to 77db0c5 Compare March 18, 2024 19:31
@nvtkaszpir
Copy link
Contributor Author

Ah ok fixed it.

@rchincha rchincha merged commit 667d010 into project-zot:main Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Add immutable tags article to the menu on the left under Articles
3 participants