Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replaced dead s3 docs url and added attributes table #163

Merged
merged 1 commit into from
Mar 25, 2024
Merged

docs: replaced dead s3 docs url and added attributes table #163

merged 1 commit into from
Mar 25, 2024

Conversation

tk-nguyen
Copy link
Contributor

What type of PR is this?
documentation

Which issue does this PR fix:
Broken S3 storage driver docs URL.

What does this PR do / Why do we need it:

  • Included an attribute table
  • Fix the broken URL.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha
Copy link
Contributor

@tk-nguyen pls add the words in the SpellCheck ci failure here:
https://github.com/project-zot/project-zot.github.io/blob/main/.wordlist.txt
(alphabetically sorted)

@rchincha
Copy link
Contributor

@tk-nguyen
Copy link
Contributor Author

@tk-nguyen pls add the words in the SpellCheck ci failure here: https://github.com/project-zot/project-zot.github.io/blob/main/.wordlist.txt (alphabetically sorted)

Once you are done, pls also sign your commit. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Done.

Copy link
Contributor

@mbshields mbshields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha
Copy link
Contributor

@tk-nguyen your PR inlines some of the documentation which I agree with since the upstream URL/docs may move/change.

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 197ead0 into project-zot:main Mar 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants