-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: LDAP separate credentials file #136
Conversation
Signed-off-by: mbshields <[email protected]>
@laurentiuNiculae pls review this also |
docs/articles/authn-authz.md
Outdated
| `skipVerify` | Skip TLS verification. | | ||
| `subtreeSearch` | Set to `true` to expand the scope for search to include subtrees of the base DN. | | ||
|
||
|
||
A local file contains the bind credentials for the LDAP server, as shown in the following example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Credentials for the LDAP server are specified in a separate file, as show ...
This model allows for separation of configuration and credentials.
(rephrase pls)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed: "To allow for separation of configuration and credentials, the credentials for the LDAP server are specified in a separate file, as shown in the following example."
docs/general/whats-new.md
Outdated
@@ -30,6 +30,10 @@ | |||
|
|||
- The validity of an image's signature can be [verified](../articles/verifying-signatures.md) by zot. Users can upload public keys or certificates to zot. | |||
|
|||
### LDAP credentials stored apart from configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"apart" -> "separate"
(maybe add this here also)
This model allows for separation of configuration and credentials.
(rephrase pls)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed: "LDAP credentials stored separately from configuration"
Signed-off-by: mbshields <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's new -> LDAP change, say that Credentials are now moved to a separate file (it is a breaking change) |
Signed-off-by: mbshields <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
documentation
Which issue does this PR fix:
none
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.