Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default settings & update notes #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

acelinkio
Copy link

@acelinkio acelinkio commented Nov 27, 2024

What type of PR is this?
cleanup

Which issue does this PR fix:
no issue

What does this PR do / Why do we need it:
Updates the default values.

  • image.tag should not be set by default.
  • service.type was NodePort. Best practice is to use ClusterIP. NodePort can be accessed externally and does not follow the principle of least privilege as a default.
  • ingress.className should not be set by default. By unsetting this value, Kubernetes will use the default class specified in the cluster.
  • image.repository used the amd64 specific image, switched to using generic image repository location

with some small edits to comments

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Arlan Lloyd <[email protected]>
@rchincha
Copy link
Contributor

@acelinkio just curious what necessitated this PR? in your particular case?

Pls also fix the ci failures.

@acelinkio
Copy link
Author

Looked for references from people in Homelab community via https://kubesearch.dev . everyone opted to not using this helm chart.

I attempted to use this chart but quickly realized I was better off just creating these manifests manually.

@rchincha
Copy link
Contributor

rchincha commented Dec 3, 2024

@acelinkio pls fix the ci failures. We will review and discuss this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants