Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove transitive dependency from takatori #36

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ban-nobuhiro
Copy link
Contributor

@ban-nobuhiro ban-nobuhiro commented Dec 18, 2024

takatori は Boost::stacktrace_backtrace への依存していましたが、推移的依存関係の設定がうまくされていなかったため、 takatori を使う側でも Boost::stacktrace_backtrace への依存を明示的に記述しないとビルドが通らなくなっていました。

上記の問題は project-tsurugi/takatori#40 で修正したので、現在記述されている Boost::stacktrace_backtrace への依存を除去します。
(takatori が Boost::stacktrace_backtrace に依存しなくなったときに邪魔になります)

Copy link
Contributor

@ashigeru ashigeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ban-nobuhiro
Copy link
Contributor Author

レビューありがとうございます。タイミングを見てマージします。

@ban-nobuhiro ban-nobuhiro merged commit acd9e51 into master Dec 19, 2024
6 checks passed
@ban-nobuhiro ban-nobuhiro deleted the fix-transitive-dependency branch December 19, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants