Skip to content

Commit

Permalink
fix old doc comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kuron99 committed Jul 7, 2024
1 parent 119a64c commit bbaf5f7
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 11 deletions.
13 changes: 6 additions & 7 deletions include/link_or_value.h
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,11 @@ class link_or_value {
}

/**
* @brief todo : write documents much.
* @param[in] new_value todo write
* @param[out] created_value_ptr todo write
* @param[out] old_value todo write
* @brief set the new value and release the old value if needed
* @param[in] new_value the new value to be set
* @param[out] created_value_ptr output parameter filled with the created value pointer
* @param[out] old_value output parameter filled with the old value pointer. If caller receives non-null pointer,
* it transfers ownership and caller is responsible for deleting the old value pointer.
*/
void set_value(value* new_value, void** const created_value_ptr,
value** old_value = nullptr) {
Expand Down Expand Up @@ -174,13 +175,11 @@ class link_or_value {
private:
/**
* @brief A flag for indicating that the next layer exists.
*
*/
static constexpr uintptr_t kChildFlag = 0b10UL << 62UL;

/**
* @brief A flag for indicating that the next layer exists.
*
* @brief A flag for indicating that the value pointer is actually a pointer (i.e. not inlined).
*/
static constexpr uintptr_t kValPtrFlag = 0b01UL << 62UL;

Expand Down
3 changes: 1 addition & 2 deletions include/thread_info_table.h
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,8 @@ class thread_info_table {
* the dependency between header files.
* @tparam border_node Class information is given at compile time to eliminate the
* dependency between header files.
* @param[in] token Session information.
* @param[in] token Session information. The behavior is undefined if the @a token is invalid.
* @return status::OK success.
* @return status::WARN_INVALID_TOKEN The @a token of the argument was invalid.
*/
template<class interior_node, class border_node>
static status leave_thread_info(Token token) {
Expand Down
3 changes: 1 addition & 2 deletions include/value.h
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,7 @@ class value {

private:
/**
* @brief A flag for indicating that the next layer exists.
*
* @brief A flag for indicating that the value pointer is actually a pointer (i.e. not inlined).
*/
static constexpr uintptr_t kValPtrFlag = 0b01UL << 62UL;

Expand Down

0 comments on commit bbaf5f7

Please sign in to comment.