Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream socket test revise #238

Open
wants to merge 28 commits into
base: stream_socket_test
Choose a base branch
from
Open

Stream socket test revise #238

wants to merge 28 commits into from

Conversation

t-horikawa
Copy link
Contributor

kuron99 and others added 24 commits September 12, 2024 15:07
@kuron99 @t-horikawa
docs: update default for sql.enable_index_join
d83a403
@kuron99 @t-horikawa
docs: remove dev_compiler_support config. parameters
b221a84
@t-horikawa
update docs/tgctl.mn
0956eaa
@t-horikawa
revise docs/tgctl.md
f093abf
@t-horikawa
follow limestone specification change that compateion_catalog file is…
c96c54c 
… added to the file list to be backed up
@t-horikawa
add description of statement event log output threshold (stmt_duratio…
e2359ee 
…n_threshold) to docs/config-parameters-altimeter_en.md
@t-horikawa
revise docs/config-parameters-altimeter_en.md
75dd68b
@t-horikawa
add docs/endpoint_metrics_ja.md
94947d5
@t-horikawa
revise docs/endpoint_metrics_ja.md in format
d1bc3e2
@t-horikawa
update docs/cli-spec-ja.md to describe 1.0.0-GA implementation status
9977fdd
@t-horikawa
revise docs/cli-spec-ja.md at version notation from 1.0.0-GA to 1.0.0
e9d1c5c
@t-horikawa
add tateyama/session/resource.h to make session_resource::sessions_co…
32baa79 
…re() available to external modules
@t-horikawa
make tateyama::session::session_resource::tag available to external m…
97c9e81 
…odules
@t-horikawa
make session_variable_set available via request
0d68534
@t-horikawa
fix session_variable_set handling
bfc128e
@t-horikawa
revise bool handling
769e4f1
@t-horikawa
fix tests that does not use session_variable_set
6477a93
@t-horikawa
fix clang-tidy warnings
d071114
@akirakw @t-horikawa
build: make RPATH relative
0c43fad
@t-horikawa
fix session_context at session_variable_set handling
d476ac3
@t-horikawa
add unset session variable functionality
a02672b
@ashigeru @t-horikawa
docs: clarify how to unset session variables.
839ced1
@ashigeru @t-horikawa
docs: make request.SessionSetVariable.value optional.
ff32e48
@t-horikawa
stream_socket_test is now actually doing the communication to check t…
c719134 
…he correctness of the operation
@t-horikawa t-horikawa requested review from a team and kuron99 as code owners September 12, 2024 06:17
@YoshiakiNishimura
Copy link
Contributor

test/tateyama/endpoint/stream/stream_receiver.hを使えば#231 もstream_writer::commitがstream_socket::send+アルファなので簡単に確認テストできそうです。ありがとうございます。

@t-horikawa
Copy link
Contributor Author

stream_write_testの方も更新しました。

@t-horikawa
Copy link
Contributor Author

よさげであれば、本PRをstream_socket_testブランチにマージした後、stream_socket_testブランチをmasterにマージしてください。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoshiakiNishimura YoshiakiNishimura YoshiakiNishimura left review comments

@kuron99 kuron99 Awaiting requested review from kuron99 kuron99 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@t-horikawa @YoshiakiNishimura @kuron99 @akirakw @ashigeru