Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce takatori::value::truncate_utf8. #39

Merged
merged 1 commit into from
Aug 27, 2024
Merged

feat: introduce takatori::value::truncate_utf8. #39

merged 1 commit into from
Aug 27, 2024

Conversation

ashigeru
Copy link
Contributor

This PR introduces a new utility function takatori::value::truncate_utf8 that truncates a UTF-8 encoded string without splitting multi-byte UTF-8 characters.

@ashigeru ashigeru requested a review from kuron99 August 27, 2024 10:35
@ashigeru ashigeru self-assigned this Aug 27, 2024
@ashigeru
Copy link
Contributor Author

related to: https://github.com/project-tsurugi/tsurugi-issues/issues/733.

kuron99
kuron99 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@kuron99 kuron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuron99 kuron99 merged commit f2c7268 into master Aug 27, 2024
6 checks passed
@kuron99 kuron99 deleted the feat-truncate-utf8 branch August 27, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuron99 kuron99 kuron99 approved these changes

Assignees

@ashigeru ashigeru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashigeru @kuron99