Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for FTBFS with gcc-13 (test code) #36

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix for FTBFS with gcc-13 (test code) #36

merged 2 commits into from
Jun 7, 2024

Conversation

ban-nobuhiro
Copy link
Contributor

#35<cstdint> の include が足りていない箇所の修正をしましたが、テストコードから使われている部分が未解消だったため、それを含めて網羅的に修正しました。
それに加えて、テストコード中の例外発生を確認するコードで std::string::data() を呼び出しているものがありますが、GCC 13 の libstdc++ からはいろいろなメソッドに [[nodiscard]] がつくようになったため、これがコンパイル時警告 (-Werro でエラー) になる問題の修正です。

@ban-nobuhiro ban-nobuhiro requested a review from ashigeru as a code owner June 6, 2024 08:14
@ashigeru ashigeru merged commit c545817 into master Jun 7, 2024
9 checks passed
@ashigeru ashigeru deleted the gcc-13 branch August 16, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants