Skip to content

Add test for handling IO errors in compaction_catalog class #662

Add test for handling IO errors in compaction_catalog class

Add test for handling IO errors in compaction_catalog class #662

GitHub Actions / Clang-Tidy failed Sep 9, 2024 in 0s

[Clang-Tidy] 9 warnings

[Clang-Tidy] 9 warnings

Annotations

Check warning on line 34 in include/limestone/api/limestone_exception.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-use-nodiscard

function 'error_code' should be marked [[nodiscard]] 

Check warning on line 58 in include/limestone/api/limestone_exception.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

cppcoreguidelines-macro-usage

function-like macro 'THROW_LIMESTONE_EXCEPTION' used; consider a 'constexpr' template function 

Check warning on line 61 in include/limestone/api/limestone_exception.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

cppcoreguidelines-macro-usage

function-like macro 'THROW_LIMESTONE_IO_EXCEPTION' used; consider a 'constexpr' template function 

Check warning on line 41 in src/limestone/file_operations.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

cppcoreguidelines-special-member-functions,hicpp-special-member-functions

class 'file_operations' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator 

Check warning on line 104 in src/limestone/file_operations.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

readability-inconsistent-declaration-parameter-name

function 'limestone::internal::real_file_operations::open_ifstream' has a definition with different parameter names 

Check warning on line 209 in src/limestone/compaction_catalog.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

cppcoreguidelines-avoid-non-const-global-variables

variable 'file_ops_' is non-const and globally accessible, consider making it const 

Check warning on line 298 in src/limestone/compaction_catalog.cpp

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

fuchsia-statically-constructed-objects

static objects are disallowed; if possible, use a constexpr constructor instead 

Check warning on line 298 in src/limestone/compaction_catalog.cpp

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

cert-err58-cpp

initialization of 'file_ops_' with static storage duration may throw an exception that cannot be caught 

Check warning on line 298 in src/limestone/compaction_catalog.cpp

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

cppcoreguidelines-avoid-non-const-global-variables

variable 'file_ops_' is non-const and globally accessible, consider making it const