Umegane dev 965 #58
Merged
Umegane dev 965 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced the `file_operations` class to provide an abstraction layer for file operations. This allows for easier dependency injection and mocking of file operations in tests.
…operations" This reverts commit df6f5f8.
- Reviewed all public APIs to ensure the correct exception specifications. - Corrected APIs that were missing or incorrectly specifying noexcept. - Updated documentation to clearly state which exceptions are thrown by each API. - Fixed several areas where exceptions were not being handled properly, ensuring robust error handling.
…nation - Modified exception handling to log errors using VLOG_LP(google::FATAL) and abort the process instead of throwing exceptions. - This is a temporary solution to prevent the system from continuing in an invalid state, as the calling code is not yet handling exceptions properly. - Once the calling code handles exceptions correctly, this change will be reverted to restore normal exception throwing behavior. - Logging ensures that error details are captured before aborting, providing diagnostic information. - Added macro HANDLE_EXCEPTION_AND_ABORT() to streamline handling across multiple APIs. - Suppressed clang-tidy warnings related to non-const global variables as part of the implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the API caller does not have a mechanism to catch limestone_exception. As it stands, if an I/O error occurs, there is a risk that the process might stall. To address this, instead of throwing a limestone_exception from APIs that have the potential to throw it, we will modify the implementation to output a FATAL log and call abort.