-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Exception Handling for I/O Errors #55
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced the `file_operations` class to provide an abstraction layer for file operations. This allows for easier dependency injection and mocking of file operations in tests.
…operations" This reverts commit df6f5f8.
- Reviewed all public APIs to ensure the correct exception specifications. - Corrected APIs that were missing or incorrectly specifying noexcept. - Updated documentation to clearly state which exceptions are thrown by each API. - Fixed several areas where exceptions were not being handled properly, ensuring robust error handling.
コンフリクトが起きているので、コンフリクトを解消したあと、もう一度プルリクを作成することにします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Limestone, the error handling for I/O errors was insufficient, particularly for public APIs, where it was unclear what exceptions might be thrown, leading to improper exception handling on the caller side.
To address this issue, the following modifications were made: