Skip to content

Commit

Permalink
cleanup: clang-tidy
Browse files Browse the repository at this point in the history
  • Loading branch information
umegane committed Oct 17, 2024
1 parent aa64958 commit 3303995
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
8 changes: 6 additions & 2 deletions include/limestone/api/snapshot.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,14 @@ namespace limestone::api {
* @brief a snapshot of the data at a point in time on the data store
*/
class snapshot {
public:

public:
snapshot() noexcept = delete;
~snapshot();
snapshot(const snapshot&) = delete;
snapshot& operator=(const snapshot&) = delete;
snapshot(snapshot&&) noexcept = delete;
snapshot& operator=(snapshot&&) noexcept = delete;
~snapshot();

/**
* @brief directory name of a snapshot
Expand Down
2 changes: 1 addition & 1 deletion src/limestone/sorting_context.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ std::optional<write_version_type> sorting_context::clear_storage_find(const stor
}

std::map<storage_id_type, write_version_type> sorting_context::get_clear_storage() const {
return clear_storage;
return clear_storage;
}

} // namespace limestone::internal
2 changes: 1 addition & 1 deletion src/limestone/sorting_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class sorting_context {
// clear_storage methods
void clear_storage_update(const storage_id_type sid, const write_version_type wv);

Check warning on line 45 in src/limestone/sorting_context.h

View workflow job for this annotation

GitHub Actions / Clang-Tidy

readability-avoid-const-params-in-decls

parameter 'sid' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions

Check warning on line 45 in src/limestone/sorting_context.h

View workflow job for this annotation

GitHub Actions / Clang-Tidy

readability-avoid-const-params-in-decls

parameter 'wv' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions
std::optional<write_version_type> clear_storage_find(const storage_id_type sid);

Check warning on line 46 in src/limestone/sorting_context.h

View workflow job for this annotation

GitHub Actions / Clang-Tidy

readability-avoid-const-params-in-decls

parameter 'sid' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions
std::map<storage_id_type, write_version_type> get_clear_storage() const;
[[nodiscard]] std::map<storage_id_type, write_version_type> get_clear_storage() const;

private:
std::unique_ptr<sortdb_wrapper> sortdb;
Expand Down

0 comments on commit 3303995

Please sign in to comment.