Skip to content

improve commit callback profiling

Sign in for the full log view
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / Clang-Tidy failed Oct 10, 2023 in 0s

[Clang-Tidy] 10 warnings

[Clang-Tidy] 10 warnings

Annotations

Check warning on line 57 in src/./jogasaki/commit_profile.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

misc-non-private-member-variables-in-classes 

member variable 'enabled_' has public visibility

Check warning on line 58 in src/./jogasaki/commit_profile.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

misc-non-private-member-variables-in-classes 

member variable 'commit_requested_' has public visibility

Check warning on line 59 in src/./jogasaki/commit_profile.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

misc-non-private-member-variables-in-classes 

member variable 'precommit_cb_invoked_' has public visibility

Check warning on line 60 in src/./jogasaki/commit_profile.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

misc-non-private-member-variables-in-classes 

member variable 'durability_cb_invoked_' has public visibility

Check warning on line 61 in src/./jogasaki/commit_profile.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

misc-non-private-member-variables-in-classes 

member variable 'commit_job_completed_' has public visibility

Check warning on line 259 in src/./jogasaki/transaction_context.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-use-nodiscard 

function 'profile' should be marked [[nodiscard]]

Check warning on line 38 in src/jogasaki/api/impl/commit_stats.cpp

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

readability-implicit-bool-conversion 

implicit conversion 'std::__atomic_base<unsigned long>::__int_type' (aka 'unsigned long') -> bool

Check warning on line 42 in src/jogasaki/api/impl/commit_stats.cpp

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

readability-implicit-bool-conversion 

implicit conversion 'std::__atomic_base<unsigned long>::__int_type' (aka 'unsigned long') -> bool

Check warning on line 46 in src/jogasaki/api/impl/commit_stats.cpp

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

readability-implicit-bool-conversion 

implicit conversion 'std::__atomic_base<unsigned long>::__int_type' (aka 'unsigned long') -> bool

Check warning on line 259 in src/jogasaki/transaction_context.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-use-nodiscard 

function 'profile' should be marked [[nodiscard]]
View more details on GitHub Actions