add stacktrace in messages on severe error

project-tsurugi/tsurugi-issues#247
project-tsurugi/tsurugi-issues#1017

src/jogasaki/error/error_info.cpp

@@ -33,15 +33,21 @@ error_info::error_info(
     std::string_view message,
     std::string_view filepath,
     std::string_view position,
-    std::string_view stacks
+    std::string_view stacks,
+    bool include_supplemental_text_in_message
 ) noexcept :
     error_code_(code),
     message_(message),
     source_file_path_(filepath),
     source_file_position_(position),
     stacks_(stacks),
     supplemental_text_(create_supplemental_text())
-{}
+{
+    if(include_supplemental_text_in_message) {
+        message_ = message_ + " " + supplemental_text_;
+        supplemental_text_ = {};
+    }
+}
 
 std::string error_info::create_supplemental_text() noexcept {
     using json = nlohmann::json;

src/jogasaki/error/error_info.h

@@ -53,7 +53,8 @@ class error_info {
         std::string_view message,
         std::string_view filepath,
         std::string_view position,
-        std::string_view stacks
+        std::string_view stacks,
+        bool include_supplemental_text_in_message = false
     ) noexcept;
 
     /**

src/jogasaki/error/error_info_factory.cpp

@@ -37,7 +37,14 @@ std::shared_ptr<error_info> create_error_info_with_stack_impl(
     status st,
     std::string_view stacktrace
 ) {
-    auto info = std::make_shared<error_info>(code, message, filepath, position, stacktrace);
+    auto info = std::make_shared<error_info>(
+        code,
+        message,
+        filepath,
+        position,
+        stacktrace,
+        ! stacktrace.empty() // if stacktrace is provided, it's severe error and message should contain it
+    );
     info->status(st);
     VLOG_LP(log_trace) << "error_info:" << *info;
     return info;

src/jogasaki/executor/process/impl/ops/details/error_abort.h

@@ -93,7 +93,7 @@ operation_status error_abort_impl(
                 filepath,
                 position,
                 res,
-                true
+                false
             );
             break;
         case status::err_insufficient_field_storage: