Skip to content

test: refactor

test: refactor #2213

Triggered via push October 18, 2023 17:22
Status Failure
Total duration 9m 44s
Artifacts

ci-build.yml

on: push
Matrix: Build
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 20 warnings
own_insert_test.insert_can_see_own_insert: test/jogasaki/cc/own_insert_test.cpp#L195
Expected equality of these values: status::ok Which is: ok tx0.commit() Which is: err_inactive_transaction Google Test trace: /__w/jogasaki/jogasaki/test/jogasaki/cc/own_insert_test.cpp:78: test occ transaction
own_insert_test.insert_can_see_own_insert: test/jogasaki/cc/own_insert_test.cpp#L195
Expected equality of these values: status::ok Which is: ok tx0.commit() Which is: err_inactive_transaction Google Test trace: /__w/jogasaki/jogasaki/test/jogasaki/cc/own_insert_test.cpp:87: test long transaction
Build (ubuntu-22.04, shirakami)
Process completed with exit code 8.
own_insert_test.insert_can_see_own_insert: _insert_test.cpp#L195
Expected equality of these values: status::ok Which is: ok tx0.commit() Which is: err_inactive_transaction Google Test trace: ../test/jogasaki/cc/own_insert_test.cpp:78: test occ transaction
own_insert_test.insert_can_see_own_insert: _insert_test.cpp#L195
Expected equality of these values: status::ok Which is: ok tx0.commit() Which is: err_inactive_transaction Google Test trace: ../test/jogasaki/cc/own_insert_test.cpp:87: test long transaction
Build (ubuntu-20.04, shirakami)
Process completed with exit code 8.
performance-unnecessary-value-param: src/jogasaki/executor/process/impl/expression/details/cast_evaluation.cpp#L159
the parameter 'dec' is copied for each invocation but only used as a const reference; consider making it a const reference
readability-simplify-boolean-expr: src/jogasaki/executor/process/impl/expression/details/cast_evaluation.cpp#L163
redundant boolean literal in conditional return statement
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L59
variable 'max_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int1, jogasaki::meta::field_type_kind::float4>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L63
variable 'max_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int2, jogasaki::meta::field_type_kind::float4>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L67
variable 'max_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int4, jogasaki::meta::field_type_kind::float4>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L71
variable 'max_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int8, jogasaki::meta::field_type_kind::float4>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L77
variable 'max_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int1, jogasaki::meta::field_type_kind::float8>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L81
variable 'max_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int2, jogasaki::meta::field_type_kind::float8>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L85
variable 'max_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int4, jogasaki::meta::field_type_kind::float8>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L89
variable 'max_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int8, jogasaki::meta::field_type_kind::float8>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L103
variable 'min_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int1, jogasaki::meta::field_type_kind::float4>' defined in a header file; variable definitions in header files can lead to ODR violations
bugprone-signed-char-misuse,cert-str34-c: src/jogasaki/executor/process/impl/expression/details/constants.h#L104
'signed char' to 'runtime_type<kind::int1>' (aka 'int') conversion; consider casting to 'unsigned char' first.
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L107
variable 'min_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int2, jogasaki::meta::field_type_kind::float4>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L111
variable 'min_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int4, jogasaki::meta::field_type_kind::float4>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L115
variable 'min_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int8, jogasaki::meta::field_type_kind::float4>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L121
variable 'min_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int1, jogasaki::meta::field_type_kind::float8>' defined in a header file; variable definitions in header files can lead to ODR violations
bugprone-signed-char-misuse,cert-str34-c: src/jogasaki/executor/process/impl/expression/details/constants.h#L122
'signed char' to 'runtime_type<kind::int1>' (aka 'int') conversion; consider casting to 'unsigned char' first.
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L125
variable 'min_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int2, jogasaki::meta::field_type_kind::float8>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L129
variable 'min_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int4, jogasaki::meta::field_type_kind::float8>' defined in a header file; variable definitions in header files can lead to ODR violations
misc-definitions-in-headers: src/jogasaki/executor/process/impl/expression/details/constants.h#L133
variable 'min_integral_float_convertible_to_int_source<jogasaki::meta::field_type_kind::int8, jogasaki::meta::field_type_kind::float8>' defined in a header file; variable definitions in header files can lead to ODR violations