Skip to content

Commit

Permalink
release: v2.11.0 r5
Browse files Browse the repository at this point in the history
fix macOS notarization
  • Loading branch information
NikhilNarayana committed Oct 18, 2023
1 parent 6d28302 commit 147c38b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .erb/scripts/windows-sign.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,6 @@ exports.default = async (config) => {
if (!output.includes("Code signed successfully")) {
throw new Error(`Failed to sign file: ${output}`);
}

console.log(output);
};
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,14 @@ jobs:
- name: Load macOS signing certificates and secrets
if: matrix.os == 'macOS-latest' && env.CERTIFICATE_MACOS_PASSWORD != null
run: |
chmod +x build/load-macos-certs-ci.sh && ./build/load-macos-certs-ci.sh
chmod +x .erb/load-macos-certs-ci.sh && ./.erb/load-macos-certs-ci.sh
mkdir -p ~/private_keys/
echo "SLIPPI_ENABLE_SIGNING=yes" >> $GITHUB_ENV
echo '${{ secrets.APPLE_CONNECT_API_KEY }}' > ~/private_keys/AuthKey_${{ secrets.APPLE_API_KEY_ID }}.p8
echo "CSC_LINK=${{ secrets.CERTIFICATE_MACOS_APPLICATION }}" >> $GITHUB_ENV
echo "CSC_KEY_PASSWORD=${{ secrets.CERTIFICATE_MACOS_PASSWORD }}" >> $GITHUB_ENV
echo "APPLE_API_KEY=${{ secrets.APPLE_API_KEY_ID }}" >> $GITHUB_ENV
echo "APPLE_API_KEY_ID=${{ secrets.APPLE_API_KEY_ID }}" >> $GITHUB_ENV
echo "APPLE_ISSUER_ID=${{ secrets.APPLE_ISSUER_ID }}" >> $GITHUB_ENV
echo "APPLE_TEAM_PROVIDER_ID=${{ secrets.APPLE_TEAM_PROVIDER_ID }}" >> $GITHUB_ENV
env:
Expand Down
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
},
"devDependencies": {
"@babel/core": "^7.17.5",
"@electron/notarize": "^2.1.0",
"@electron/notarize": "^1.2.4",
"@electron/rebuild": "^3.3.0",
"@emotion/babel-preset-css-prop": "^11.2.0",
"@pmmmwh/react-refresh-webpack-plugin": "0.5.5",
Expand Down Expand Up @@ -97,8 +97,6 @@
"electron": "^19.1.9",
"electron-builder": "^23.3.3",
"electron-devtools-installer": "^3.2.0",
"electron-notarize": "^1.2.1",
"electron-rebuild": "^3.2.7",
"electronmon": "^2.0.2",
"eslint": "^7.15.0",
"eslint-config-prettier": "^8.5.0",
Expand Down

0 comments on commit 147c38b

Please sign in to comment.