Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playback] Process paths in slippi combo files relative to the config itself #202

Open
wants to merge 3 commits into
base: slippi
Choose a base branch
from

Conversation

FluentCoding
Copy link
Contributor

@FluentCoding FluentCoding commented Oct 9, 2020

So that the configuration files for combos can be distributed together with the replays, the replays must be relative to the configuration file itself and not to the .exe of Dolphin (I'm doing this for clippi).

I tested it on Windows 10, with absolute and relative paths working perfectly, but I didn't test it on Unix (Linux/macOS) yet.

@FluentCoding FluentCoding changed the title Process paths in slippi combo files relative to the config itself [Playback] Process paths in slippi combo files relative to the config itself Oct 19, 2020
@NikhilNarayana
Copy link
Member

Can I get an example zip to test with?

@vinceau
Copy link
Member

vinceau commented Dec 1, 2020

I envision the zip structure could look something like this:

combos.zip
├── combos.json
└── slp
    ├── Game_1234.slp
    └── Game_5678.slp

I also think it's worth considering this a little bit deeper. It would be nice if there was some sort new file format which encompasses a set of SLP files, maybe call it SLPS, or something. It would be good if the Desktop app could also have file association support for this new format such that I could send someone a SLPS file, they can simply double click that file, and have it automatically unzip maybe in a temp folder, and open automatically load the JSON file into Dolphin. Better yet, if Dolphin could read the JSON and the SLP files without us even having to unzip it.

This could allow for much easier distribution of tournament SLPs. There's also potential for metadata to be included, so that player characters, game results, name tags could be easily extracted too.

But that can be for another day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants