Ensure the rooms list is always freshly updated #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes an `Event::Signal` gets lost (applied to a different event generation), so we were missing them in the rooms_list event handler. This manifested as some rooms failing to be displayed if they were discovered after a user had clicked away from the rooms_list screen and then navigated back to the screen. Now, we check for updates to the rooms on every event handler, which ensures we never miss any updates even if an `Event::Signal` was missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes an
Event::Signalgets lost (applied to a different event generation), so we were missing them in the rooms_list event handler. This manifested as some rooms failing to be displayed if they were discovered after a user had clicked away from the rooms_list screen and then navigated back to the screen.Now, we check for updates to the rooms on every event handler, which ensures we never miss any updates even if an
Event::Signalwas missed.