Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the text color of the search bar to be darker when it is not empty #317

Closed

Conversation

tyreseluo
Copy link
Contributor

Related PRs

PR Content

Set the text color of the search bar to be darker when it is not empty.

Problems

None

@tyreseluo tyreseluo added waiting-on-author This issue is waiting on the original author for a response waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Jan 7, 2025
@kevinaboos
Copy link
Member

Thanks! While this approach technically works, it is not the right way to set text color based on state -- that should be done in the shader code. We actually don't need to run any Rust code-level checks for this at all.

I have an upcoming PR that fixes some loginscreen format issues, and it will address this among other things. So I'll close this in favor of that more canonical approach.

@kevinaboos kevinaboos closed this Jan 7, 2025
@kevinaboos kevinaboos removed the waiting-on-review This issue is waiting to be reviewed label Jan 7, 2025
@kevinaboos
Copy link
Member

See #318 for the improved way of handling text colors for all TextInput widgets, which is done via shader code

@tyreseluo
Copy link
Contributor Author

Thank you so much. I'm learning in the shader language piece, thanks for the perfect example.

@tyreseluo tyreseluo deleted the not_empty_darker_search_bar branch January 9, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants