Replace AdaptiveView with Makepad's version. Fixes rooms search bug. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joulei
commented
Jan 6, 2025
kevinaboos
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on makepad/makepad#629 - merged ✅
Changes
Replaces
AdaptiveViewwith the newly ported version in Makepad. (you'll notice some small API changes)In Robrix's version,
AdaptiveViewalways creates a default active widget onafter_apply_from. This is problematic becauseRoomPreviewsets theAdaptiveViewvariant selector in itsafter_new_from_docwhich is called afterAdaptiveView's(or any of its children)after_apply_from. This was causing some lifecycle issues where the AdaptiveView would require another redraw after its parentafter_new_from_doc, causing some visual artifacts.