Display number of unread messages as a badge on the jump-to-bottom button. Send fully-read receipts more efficiently. #206

alanpoon · 2024-10-15T04:09:55Z

Implemented: Start a 5-second timeout timer whenever scrolling stops, and then after the timer has reached its timeout deadline, send the read receipts for the last visible event.
Modified Send fully Receipt condition to be executed only after scrolling past Fully Read Marker
Added obtaining Fully read marker's event_id Request

Added Jump to Top view
Added Jump to bottom badge counter

scrollup2.mp4

kevinaboos

See my comments about the Jump to Top (JTT) button -- we're not yet ready to properly implement that, so I think it should be removed, or at least hidden until we can fix it.

Everything else looks fine, thanks!

resources/icon_jump_to_top.svg

src/home/room_screen.rs

src/sliding_sync.rs

src/home/room_screen.rs

src/sliding_sync.rs

src/home/room_screen.rs

alanpoon · 2024-11-06T10:12:46Z

Currently there's a bug in the portallist's is_at_end function which returns true even when the scroll is not at the bottom. Hence the JTB will not show.
makepad/makepad#579

kevinaboos

left some more comments.

It appears that you haven't yet addressed my previous requests here and here to properly center-align the unread messages badge with the jump-to-bottom button. Please fix that, and then we can merge this in.

~~We can add the subscribe/unsubscribe functionality later if you can't solve it here in this PR. I have some solutions in mind.~~

I will add the unsubscribing functionality myself in a future PR, so don't worry about it now. Let's move forward and get this PR finished up.

src/home/room_screen.rs

src/shared/jump_to_bottom_button.rs

src/sliding_sync.rs

src/shared/jump_to_bottom_button.rs

Co-authored-by: Kevin Boos <[email protected]>

alanpoon · 2025-01-01T02:23:56Z

left some more comments.

It appears that you haven't yet addressed my previous requests here and here to properly center-align the unread messages badge with the jump-to-bottom button. Please fix that, and then we can merge this in.

~~We can add the subscribe/unsubscribe functionality later if you can't solve it here in this PR. I have some solutions in mind.~~

I will add the unsubscribing functionality myself in a future PR, so don't worry about it now. Let's move forward and get this PR finished up.

Fixed center align issue

kevinaboos

Thanks very much! I'm pleased to say that this is finally ready to merge. I appreciate your patience and dedication to getting things right.

I did have to make some changes, please take a look to get a sense of the code style and type of improvements i was hoping for: ab540fd

alanpoon · 2025-01-03T02:37:46Z

Thanks very much! I'm pleased to say that this is finally ready to merge. I appreciate your patience and dedication to getting things right.

I did have to make some changes, please take a look to get a sense of the code style and type of improvements i was hoping for: ab540fd

Ok noted

alanpoon added 14 commits October 4, 2024 12:31

reduce complexity of send_read_receipt

5657931

cleanup

bb92afb

removed unnecessary import

9255365

added unread_message_badge

24be468

remove unneccesary changes

c1d1ab6

add jump to top

35c5977

added unread_notification_badge

bc2aa8c

Merge branch 'main' into jtb_change_in_timeline_item#131

a9e4945

Merge branch 'main' into send_read_receipt_improve

053c8f0

Added scroll past marker

e4c1268

Merge branch 'jtb_change_in_timeline_item#131' into send_read+jtb

072b9cb

wip

3884a66

send read +jtb

b7a83a0

Merge branch 'main' into send_read+jtb

a3b1f10

kevinaboos requested changes Oct 30, 2024

View reviewed changes

alanpoon added 4 commits November 4, 2024 11:03

added some docs, remove icon_jump_to_top

3824160

Merge branch 'main' into send_read+jtb

5633e2b

merge .cargo

44f4c25

minor formating

9076c53

alanpoon commented Nov 4, 2024

View reviewed changes

src/home/room_screen.rs Outdated Show resolved Hide resolved

alanpoon added 5 commits November 4, 2024 21:22

change to start_timeout

5bf2413

Merge branch 'main' into send_read+jtb

1c66730

removed jump_to_top & fix timer issue

8bbde58

set read event into RoomInfo's fully read when sending

b99a57d

restructure scroll pass read marker logic

99ff1b1

alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Dec 31, 2024

kevinaboos requested changes Dec 31, 2024

View reviewed changes

kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels Dec 31, 2024

alanpoon and others added 8 commits January 1, 2025 09:32

Doc fix

50a5cce

Co-authored-by: Kevin Boos <[email protected]>

Doc fix

5ed414b

Co-authored-by: Kevin Boos <[email protected]>

Unread fix typo

ed649a0

Co-authored-by: Kevin Boos <[email protected]>

Doc Fix

c156d5a

Co-authored-by: Kevin Boos <[email protected]>

Doc Fix

2f746d0

Co-authored-by: Kevin Boos <[email protected]>

fix copy-paste error message here

81ed2f1

Co-authored-by: Kevin Boos <[email protected]>

Fix spelling

9f55e61

center align the unread badge

43c3104

Merge remote-tracking branch 'origin' into send_read+jtb

7c58b5f

alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Jan 1, 2025

alanpoon and others added 4 commits January 1, 2025 10:28

restore whitespace

2b2a9dc

Merge branch 'main' into send_read+jtb

077c23a

simplify unread message handling and code structure

ab540fd

clippy fix

2f9d2a2

kevinaboos approved these changes Jan 2, 2025

View reviewed changes

kevinaboos requested review from kevinaboos and aaravlu January 2, 2025 20:42

kevinaboos approved these changes Jan 2, 2025

View reviewed changes

kevinaboos merged commit 443d04d into project-robius:main Jan 2, 2025
3 checks passed

This was referenced Jan 2, 2025

Upon hiding a room timeline, unsubscribe to "own user read receipts" update loop #315

Open

[Feature] Show number of unread messages in room. #314

Open

kevinaboos removed the waiting-on-review This issue is waiting to be reviewed label Jan 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display number of unread messages as a badge on the jump-to-bottom button. Send fully-read receipts more efficiently. #206

Display number of unread messages as a badge on the jump-to-bottom button. Send fully-read receipts more efficiently. #206

alanpoon commented Oct 15, 2024 •

edited

Loading

kevinaboos left a comment

alanpoon commented Nov 6, 2024

kevinaboos left a comment •

edited

Loading

alanpoon commented Jan 1, 2025

kevinaboos left a comment

alanpoon commented Jan 3, 2025

Display number of unread messages as a badge on the jump-to-bottom button. Send fully-read receipts more efficiently. #206

Display number of unread messages as a badge on the jump-to-bottom button. Send fully-read receipts more efficiently. #206

Conversation

alanpoon commented Oct 15, 2024 • edited Loading

kevinaboos left a comment

Choose a reason for hiding this comment

alanpoon commented Nov 6, 2024

kevinaboos left a comment • edited Loading

Choose a reason for hiding this comment

alanpoon commented Jan 1, 2025

kevinaboos left a comment

Choose a reason for hiding this comment

alanpoon commented Jan 3, 2025

alanpoon commented Oct 15, 2024 •

edited

Loading

kevinaboos left a comment •

edited

Loading