Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNe Id, Idn, Ie, Ien, and LRN #25

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Conversation

Theodlz
Copy link
Contributor

@Theodlz Theodlz commented Oct 7, 2024

This PR adds:

  • a subtype of Novae: Luminous Red Nova (LRN)
  • 4 new SNe subtypes: Id, Idn, Ie, Ien

This is based on user requests, that need this in the Sitewide taxonomy of SkyPortal (that reads its content from this repo's main branch).

@Theodlz
Copy link
Contributor Author

Theodlz commented Oct 7, 2024

Feel free to make any changes!

@Theodlz
Copy link
Contributor Author

Theodlz commented Oct 7, 2024

@profjsb

Copy link
Owner

@profjsb profjsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tiny change requested.

tdtax/supernovae.yaml Outdated Show resolved Hide resolved
tdtax/supernovae.yaml Outdated Show resolved Hide resolved
@Theodlz Theodlz requested a review from profjsb October 8, 2024 05:53
Copy link
Owner

@profjsb profjsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profjsb profjsb merged commit fd50c11 into profjsb:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants